Skip to content

[GG clean] fix(dcp): preallocate packed A2A graph buffers - #141

Closed
voipmonitor wants to merge 1 commit into
dev/gilded-gnosisfrom
fix/gg-dcp-a2a-prewarm-clean-20260720
Closed

[GG clean] fix(dcp): preallocate packed A2A graph buffers#141
voipmonitor wants to merge 1 commit into
dev/gilded-gnosisfrom
fix/gg-dcp-a2a-prewarm-clean-20260720

Conversation

@voipmonitor

@voipmonitor voipmonitor commented Jul 20, 2026

Copy link
Copy Markdown

Summary

Reapply the useful part of previous PR #130 after resetting dev/gilded-gnosis back before the Jul 20 merge/revert block.

This keeps the DCP packed A2A graph-buffer lifetime fix, without bringing back the discarded CUTLASS pin or the old MLA .contiguous() workaround.

Original PR

Changes

  • Preallocate/retain packed A2A send/recv graph buffers when CUDA graph capture is active.
  • Add unit coverage for graph prewarm buffer retention and eager non-retention behavior.

Merge Order

This is the first PR in the clean GG reapply stack.

Do not merge until explicitly approved.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@voipmonitor, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f79ea547-ce83-4dbc-b5ed-1ce74f3e107d

📥 Commits

Reviewing files that changed from the base of the PR and between 371085e and 3fe930a.

📒 Files selected for processing (2)
  • tests/distributed/test_dcp_a2a.py
  • vllm/v1/attention/ops/dcp_alltoall.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/gg-dcp-a2a-prewarm-clean-20260720

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Jul 20, 2026
Closed
Closed
Merged
@voipmonitor

voipmonitor commented Jul 21, 2026

Copy link
Copy Markdown
Author

Closing as already represented in the current dev/gilded-gnosis base. The packed A2A graph-buffer prewarm behavior and its tests are present there via 639aeff, so this conflicting branch has no unique change left to merge. The follow-on lifecycle work is consolidated in #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@voipmonitor